Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: flask-whooshee invoked whoosh searcher without limit, so whoosh used defalt limit value == 10 #7

Merged
merged 3 commits into from Oct 31, 2014

Conversation

evilkost
Copy link

No description provided.

bkabrda pushed a commit that referenced this pull request Oct 31, 2014
bugfix: flask-whooshee invoked whoosh searcher without `limit`, so whoosh  used defalt limit value == 10
@bkabrda bkabrda merged commit f4efdec into fedora-copr:master Oct 31, 2014
@bkabrda
Copy link
Collaborator

bkabrda commented Oct 31, 2014

Merged, thanks a lot!

@xsuchy
Copy link
Member

xsuchy commented Oct 31, 2014

Isn't it better to use search_page() instead? So you can use search_page(q, 9, page_len=10) instead of search(q, 100)?

@bkabrda
Copy link
Collaborator

bkabrda commented Oct 31, 2014

Isn't it better to use search_page() instead? So you can use search_page(q, 9, page_len=10)
instead of search(q, 100)?

That actually depends on your usecase. I'm willing to accept any patches that would introduce the possiblity to do paged search, assuming the relevant whooshee_search arguments are introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants