Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTERNALERROR with pytest-4.1.0 #27

Closed
jpopelka opened this issue Jan 6, 2019 · 1 comment · Fixed by #28
Closed

INTERNALERROR with pytest-4.1.0 #27

jpopelka opened this issue Jan 6, 2019 · 1 comment · Fixed by #28
Labels
bug upstream

Comments

@jpopelka
Copy link
Contributor

jpopelka commented Jan 6, 2019 •
edited 

PYTHONPATH=/home/jpopelka/git/user-cont/ferdinand pytest --color=yes --verbose --showlocals
============================================================================================================ test session starts =============================================================================================================
platform linux -- Python 3.7.2, pytest-4.1.0, py-1.7.0, pluggy-0.8.0 -- /home/jpopelka/.virtualenvs/user-cont/bin/python3
cachedir: .pytest_cache
rootdir: /home/jpopelka/git/user-cont/ferdinand, inifile: pytest.ini
plugins: celery-4.2.1
collected 49 items                                                                                                                                                                                                                           

tests/test_errata.py::TestErrata::test_is_release_valid 
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/home/jpopelka/.virtualenvs/user-cont/lib/python3.7/site-packages/_pytest/main.py", line 203, in wrap_session
INTERNALERROR>     session.exitstatus = doit(config, session) or 0
INTERNALERROR>   File "/home/jpopelka/.virtualenvs/user-cont/lib/python3.7/site-packages/_pytest/main.py", line 243, in _main
INTERNALERROR>     config.hook.pytest_runtestloop(session=session)
INTERNALERROR>   File "/home/jpopelka/.virtualenvs/user-cont/lib/python3.7/site-packages/pluggy/hooks.py", line 284, in __call__
INTERNALERROR>     return self._hookexec(self, self.get_hookimpls(), kwargs)
INTERNALERROR>   File "/home/jpopelka/.virtualenvs/user-cont/lib/python3.7/site-packages/pluggy/manager.py", line 67, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook, methods, kwargs)
INTERNALERROR>   File "/home/jpopelka/.virtualenvs/user-cont/lib/python3.7/site-packages/pluggy/manager.py", line 61, in <lambda>
INTERNALERROR>     firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
INTERNALERROR>   File "/home/jpopelka/.virtualenvs/user-cont/lib/python3.7/site-packages/pluggy/callers.py", line 208, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>   File "/home/jpopelka/.virtualenvs/user-cont/lib/python3.7/site-packages/pluggy/callers.py", line 80, in get_result
INTERNALERROR>     raise ex[1].with_traceback(ex[2])
INTERNALERROR>   File "/home/jpopelka/.virtualenvs/user-cont/lib/python3.7/site-packages/pluggy/callers.py", line 187, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File "/home/jpopelka/.virtualenvs/user-cont/lib/python3.7/site-packages/_pytest/main.py", line 264, in pytest_runtestloop
INTERNALERROR>     item.config.hook.pytest_runtest_protocol(item=item, nextitem=nextitem)
INTERNALERROR>   File "/home/jpopelka/.virtualenvs/user-cont/lib/python3.7/site-packages/pluggy/hooks.py", line 284, in __call__
INTERNALERROR>     return self._hookexec(self, self.get_hookimpls(), kwargs)
INTERNALERROR>   File "/home/jpopelka/.virtualenvs/user-cont/lib/python3.7/site-packages/pluggy/manager.py", line 67, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook, methods, kwargs)
INTERNALERROR>   File "/home/jpopelka/.virtualenvs/user-cont/lib/python3.7/site-packages/pluggy/manager.py", line 61, in <lambda>
INTERNALERROR>     firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
INTERNALERROR>   File "/home/jpopelka/.virtualenvs/user-cont/lib/python3.7/site-packages/pluggy/callers.py", line 208, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>   File "/home/jpopelka/.virtualenvs/user-cont/lib/python3.7/site-packages/pluggy/callers.py", line 80, in get_result
INTERNALERROR>     raise ex[1].with_traceback(ex[2])
INTERNALERROR>   File "/home/jpopelka/.virtualenvs/user-cont/lib/python3.7/site-packages/pluggy/callers.py", line 187, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File "/home/jpopelka/.virtualenvs/user-cont/lib/python3.7/site-packages/_pytest/runner.py", line 78, in pytest_runtest_protocol
INTERNALERROR>     runtestprotocol(item, nextitem=nextitem)
INTERNALERROR>   File "/home/jpopelka/.virtualenvs/user-cont/lib/python3.7/site-packages/_pytest/runner.py", line 93, in runtestprotocol
INTERNALERROR>     reports.append(call_and_report(item, "call", log))
INTERNALERROR>   File "/home/jpopelka/.virtualenvs/user-cont/lib/python3.7/site-packages/_pytest/runner.py", line 173, in call_and_report
INTERNALERROR>     call = call_runtest_hook(item, when, **kwds)
INTERNALERROR>   File "/home/jpopelka/.virtualenvs/user-cont/lib/python3.7/site-packages/flexmock.py", line 1227, in call_runtest_hook
INTERNALERROR>     teardown = runner.CallInfo(flexmock_teardown, when=when)
INTERNALERROR> TypeError: __init__() missing 3 required positional arguments: 'excinfo', 'start', and 'stop'

Downgrading to pytest-4.0.2 makes it work again.
@jpopelka
Copy link
Contributor Author

jpopelka commented Jan 7, 2019

See pytest-dev/pytest@847eace

jpopelka added a commit to jpopelka/flexmock that referenced this issue Jan 7, 2019
@jpopelka
Make _hook_into_pytest() work with pytest-4.1
5666253 
This is however not backward compatible with pytest<4.1 since the
runner.CallInfo.from_call() was added in 4.1.0
pytest-dev/pytest@847eace

Fixes flexmock#27
@jpopelka jpopelka mentioned this issue Jan 7, 2019
Merged
jpopelka added a commit to jpopelka/flexmock that referenced this issue Jan 7, 2019
@jpopelka
Make _hook_into_pytest() work with pytest-4.1
8e8ffcf 
runner.CallInfo.from_call() was added with
pytest-dev/pytest@847eace

Fixes flexmock#27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make _hook_into_pytest() work with pytest-4.1 jpopelka/flexmock
2 participants
@jpopelka @ollipa