Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skada and ElvUI_Enhanced #49

Closed
Frixen opened this issue Jun 8, 2021 · 5 comments
Closed

Skada and ElvUI_Enhanced #49

Frixen opened this issue Jun 8, 2021 · 5 comments

Comments

@Frixen
Copy link

Frixen commented Jun 8, 2021

Please add Skada report compatibility for
https://github.com/ElvUI-WotLK/ElvUI_Enhanced/blob/master/ElvUI_Enhanced/Modules/Chat/DPSLinks.lua

@bkader
Copy link
Owner

bkader commented Jun 8, 2021

Hello @Frixen. This was fixed but not yet pushed. It will be fixed on the next update asap.

@Frixen
Copy link
Author

Frixen commented Jun 8, 2021

Hello @Frixen. This was fixed but not yet pushed. It will be fixed on the next update asap.

Ty:)

@bkader bkader closed this as completed in a61a04d Jun 9, 2021
@Frixen
Copy link
Author

Frixen commented Jun 12, 2021

Hello @Frixen. This was fixed but not yet pushed. It will be fixed on the next update asap.

Hi @bkader. Still not working, Elvui does not handle spam from Scud. This is how it should work:
image

@bkader
Copy link
Owner

bkader commented Jun 12, 2021

@Frixen it is sadly a problem with ElvUI_Enhanced DPSLinks.lua file and not Skada.
You can fix this by editing the file ElvUI_Enhanced\Modules\Chat\DPSLinks.lualua:

local spamFirstLines = {
	"^Recount - (.*)$",				-- Recount
	"^Skada: (.*) for (.*):$",		-- Skada enUS
	"^Skada: (.*) por (.*):$",		-- Skada esES/ptBR
	"^Skada: (.*) für (.*):$",		-- Skada deDE
--	"^Skada: (.*) fur (.*):$",		-- Skada deDE
	"^Skada: (.*) pour (.*):$",		-- Skada frFR
	"^Skada: (.*) для (.*):$",		-- Skada ruRU
--	"^Skada: (.*) per (.*):$",		-- Skada itIT
	"^(.*) 의 Skada 보고 (.*):$",	-- Skada koKR
	"^Отчёт Skada: (.*), с (.*):$",	-- Skada ruRU
	"^Skada报告(.*)的(.*):$",		-- Skada zhCN
	"^Skada:(.*)來自(.*):$",			-- Skada zhTW
	"^(.*) Done for (.*)$",			-- TinyDPS
	"^Details!:(.*)$" -- Details!
}

local spamNextLines = {
	"^(%d+)%. (.*)$",	-- Recount, Skada
	"^ (%d+). (.*)$",	-- Skada
	"^(%d+). (.*)$", -- Recount, Details! and Skada
	"^(.*)  (.*)$", -- Additional Skada
	"^.*%%%)$",			-- Skada player details
	"^(%d+). (.*):(.*)(%d+)(.*)(%d+)%%(.*)%((%d+)%)$", -- TinyDPS
}

Or you can disable this on ElvUI and just use Spamage module From Skada, it does the same thing.

@Barsoomx
Copy link

	"^(%d+). (.*)$", -- Recount, Details! and Skada
	"^(.*)  (.*)$", -- Additional Skada

we figured those are not needed, only the localisation part. I'll merge it into elvui-enhanced repo...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants