Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullability is broken by move to reference schemas #201

Closed
brizzbuzz opened this issue Feb 19, 2022 · 1 comment · Fixed by #286
Closed

Nullability is broken by move to reference schemas #201

brizzbuzz opened this issue Feb 19, 2022 · 1 comment · Fixed by #286
Labels
bug Something isn't working

Comments

@brizzbuzz
Copy link
Contributor

Describe the bug
The switch to reference schemas completely broken Kompendiums ability to handle null fields. Since each type gets stored only once, but nullability is stored on the object schema level, this leads to a situation where defining one field of Type A that is nullable and another field of type A that is not nullable cannot be handled.

To Reproduce

data class Something(val a: String, val b: Int)

data class ManyThings(
  val someA: Something,
  val someB: Something?
)

This will not display the nullability correctly in Kompendium

Expected behavior
It should display properly

@brizzbuzz brizzbuzz added the bug Something isn't working label Feb 19, 2022
@brizzbuzz
Copy link
Contributor Author

Read through this at some point OAI/OpenAPI-Specification#1368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant