(hooks) Job initialize called on create

[gregory-m]

Hi.

In hooks branch you suggest to move all finders into job initialize method, and only this method will get arguments.

But you call initialize on job creation, so this will double my DB queries. Yes I can do some thing like this:

class ProcessPresentation < Qu::Job
  def initialize(presentation_id)
    @presentation_id = presentation_id
  end

  def perform
     Presentation.find(@presentation_id).process!
  end
end

But this looks like a hack for me.

[bkeepers]

This is something that I debated in my head about for a long time and still don't feel satisfied with the solution yet. My goal was to have the job in the same state for any of the hooks. Unfortunately, as you point out, that means that it may have to do lookups for the enqueue hooks.

By passing the args to initialize, people can do whatever they want with them.

I also kicked around the idea of making the Job class act like a struct:

class ProcessPresentation < Qu::Job.new(:presentation_id)
  def perform
     Presentation.find(presentation_id).process!
  end
end

In the end, I decided that it didn't feel right, and I'd rather keep jobs as close to a normal Ruby object as possible.

I'm open to suggestions.

[jnunemaker]

This is what I typically do and what I would recommend once hooks branch lands:

class ProcessPresentation < Qu::Job
  def initialize(presentation_id)
    @presentation_id = presentation_id
  end

  def presentation
    @presentation ||= Presentation.find(@presentation_id)
  end

  def perform
    presentation.process!
  end
end