Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test \r\n in WhitespaceControlTest.java #68

Closed
ilg-ul opened this issue Dec 28, 2017 · 1 comment
Closed

Test \r\n in WhitespaceControlTest.java #68

ilg-ul opened this issue Dec 28, 2017 · 1 comment

Comments

@ilg-ul
Copy link

ilg-ul commented Dec 28, 2017

Although with the current version that always removes all whitespaces it might not be a problem, for correctness, I think it would be better to also test Windows specific cases too.

This means doubling all tests that use \n with similar ones using \r\n.

In my fork that removes only one line terminator, the test file looks like this:

The adjusted parser that passes these tests is:

@bkiers
Copy link
Owner

bkiers commented Mar 8, 2018

With the rewrite of the grammar (from v3 to v4), the Windows \r\n pass out of the box. Unit tests are added in #81

@bkiers bkiers closed this as completed Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants