Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on user_factory for testing #75

Closed
rezmuh opened this issue Nov 6, 2023 · 2 comments · Fixed by #76
Closed

Question on user_factory for testing #75

rezmuh opened this issue Nov 6, 2023 · 2 comments · Fixed by #76

Comments

@rezmuh
Copy link

rezmuh commented Nov 6, 2023

I found this in the service_test of user domain:

let user = user_factory::create_user_with_username("test-username");

I cloned the project but could not find the definition of create_user_with_username function. Where is it defined?

Thank you

@bkonkle
Copy link
Owner

bkonkle commented Nov 7, 2023

Hi! This is a test file that was accidentally left behind. 😅 I forgot to delete that file when I moved the User Service tests to libs/domains/src/users/tests/service_test.rs.

The user_factory was leftover from a previous iteration. The last version of it can be found here. Afterwards, I removed the factories and went to using the Dummy derive from the fake crate.

I'll remove the old files now. Thank you for letting me know!

@rezmuh
Copy link
Author

rezmuh commented Nov 8, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants