Regex exprerssions not correctly formed!!!

[WallyZambotti]

Given

rex_header_all = new Regex("(?:" + NATIVE_ARCH + """/|>)?linux-headers-[a-zA-Z0-9.\-_]*_all.deb""");
Where NATIVE_ARCH = 'arm64' and the expression equals:

(?:arm64/|>)?linux-headers-[a-zA-Z0-9.\-_]*_all.deb
Should not match the following :

&nbsp;&nbsp;<a href="amd64/linux-headers-5.8.12-050812_5.8.12-050812.202009261732_all.deb">amd64/linux-headers-5.8.12-050812_5.8.12-050812.202009261732_all.deb</a><br>

However it does!

Because arm64 does not equal amd64. Otherwise why bother explicitly providing NATIVE_ARCH?

[WallyZambotti]

This can be fixed by making the following two changes:

1. In initialize_regex() Remove the '?' for 0 or 1 occurrences of NATIVE_ARCH

rex_header_all = new Regex("(?:" + NATIVE_ARCH + """/|>)?linux-headers-[a-zA-Z0-9.\-_]*_all.deb""");

replace for

rex_header_all = new Regex("(?:" + NATIVE_ARCH + """/|>)linux-headers-[a-zA-Z0-9.\-_]*_all.deb""");
Which then breaks load_cached_page() which insists on having '_all' headers.

2 In load_cached_page() remove the requirement for all headers

			// Not all architectures have '_all' headers. This would only allow amd64 to succeed

			if ((deb_header.length == 0) /* || (deb_header_all.length == 0) */ || (deb_image.length == 0)){
				mark_invalid();
			}

[bkw777]

Thank you for this. I'll check it out.

[bkw777]

I think the 0 or 1 instance of arch is because old kernel versions on the web site didn't have arch subdirectores, but later ones do. I'll try to test this with a forced/faked arch and see if I can see what you're describing.

[bkw777]

Apparently no longer a problem. Testing in an arm64 vm and it's matching correctly.