Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the “Shortcuts” icon in the Home settings #693

Closed
Aleksandra0056 opened this issue Apr 19, 2023 · 4 comments
Closed

Replace the “Shortcuts” icon in the Home settings #693

Aleksandra0056 opened this issue Apr 19, 2023 · 4 comments
Labels
Class::Icon Icon for panels, menus, libraries Component::UserContents Page related issues except Activity-Stream, not browser UI Issue::Enhancement New feature or request Issue::Wontfix This will not be worked on

Comments

@Aleksandra0056
Copy link
Contributor

Aleksandra0056 commented Apr 19, 2023 •
edited
Loading

Is your feature request related to a problem?

There is a new (and better) icon in the PDF reader. I don't like the thick icon in the Home section in about:preferences.

NOTE: The old icon (in about:preferences) is probably Photon, and the new icon (in PDF reader) is surely Proton.

Replace this icon…

Old shortcuts icon

The solution I'd like

…With this icon:

Replace the Shortcuts icon with this icon

Screenshots or video

No response

Alternatives I've considered

No response

Additional context

— I'm using Firefox 112.0.1, so the new icons in PDF reader are not available in the ESR I think.
@Aleksandra0056 Aleksandra0056 added the Issue::Enhancement New feature or request label Apr 19, 2023
@Aleksandra0056
Copy link
Contributor Author

Aleksandra0056 commented Apr 19, 2023 •
edited
Loading

By the way, some of these new icons in the PDF were created thanks to me (because I reported that feature request in BugZilla).

@black7375
Copy link
Owner

I don't think current icon is bad.

@black7375 black7375 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2023
@black7375 black7375 added Issue::Wontfix This will not be worked on Class::Icon Icon for panels, menus, libraries Component::UserContents Page related issues except Activity-Stream, not browser UI labels Apr 19, 2023
@Aleksandra0056
Copy link
Contributor Author

Aleksandra0056 commented Apr 20, 2023 •
edited
Loading

But why? The newer icon have thinner lines (and the old one is very thick). In short, the old icon (in 1st screenshot) is not consistent to Proton design. Also, I think, that the old icon is from Photon.

I don't want be rude, but following the Proton design standards is “Won't fix”?

@Aleksandra0056
Copy link
Contributor Author

Aleksandra0056 commented Apr 20, 2023 •
edited
Loading

I'm so sorry for advocating my issue, so I decided to rather file a new bug in BugZilla. Keep this as Won't fix if you want.

UPDATE: It happened, https://bugzilla.mozilla.org/show_bug.cgi?id=1829141

@Aleksandra0056 Aleksandra0056 mentioned this issue Jun 15, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Class::Icon Icon for panels, menus, libraries Component::UserContents Page related issues except Activity-Stream, not browser UI Issue::Enhancement New feature or request Issue::Wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@black7375 @Aleksandra0056