-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-account containers new tab context selection menu display issue #26
Comments
There may be a problem with forcing the size to be specified. |
There is no bugs when I tested in same environment(Windows/System Default). bug_replay1.mp4 |
I just downloaded the latest version and whatever the problem was, it is gone now. |
Here's the video 2021-06-02.11-54-57.mp4and the userChrome.css I was using that causes the issue, not sure which commit that was:
|
@black7375 I think this repository have to versioning for user like this issue. |
I can confirm that I just updated and the issue is now gone for me too. edit: tested on another computer, update doesn't fix issue. |
I'll release 1.0 when the three high-priority issues are resolved. |
@guyman70718 Failed to reproduce bug. Any information that can help you solve it? |
Well both machines are running Windows 10 x64 with Firefox 89.0 stable branch. Both machines are using the photon-style branch of Lepton. On the machine where I get the weird collapsed context menu, I can still right click the menu and have it work but if I hold down it is collapsed. Any other info you think could help? I can provide a video if you'd like... Edit: just tested dragging tabs around, and the machine where container tabs works fine the tabs dont sink into the URL bar like the other computer. Both are using compact style. |
@guyman70718 Lines 538 to 558 in 1a345f5
Please delete this code and try |
I could not find the code you mentioned but I saw that you recently updated the photon style css again, so I updated to the latest version and the issue is now fixed, along with dragging tabs. Thanks for all the work you are putting into this theme, I much prefer it to proton |
Ok, first things first, close issue. Thanks for testing 👍 |
Describe the bug
With Multi-Account Containers extension installed, the menu to select new tab context doesn't display correctly (height is to low) when opened by dragging the new tab button down with left mouse button.
Expected behavior
The menu should be displayed as in the in the original proton theme or like when right-clicking the new tab button.
Screenshots
![containers_proton](https://user-images.githubusercontent.com/20592214/120427800-e2947400-c372-11eb-943f-63c50c3aa8eb.png)
Proton - Drag down:
Lepton - Drag down:
![containters_lepton](https://user-images.githubusercontent.com/20592214/120427805-e4f6ce00-c372-11eb-8523-a7f650d6650c.png)
Lepton - Right-click:
![containers_leption_rmb](https://user-images.githubusercontent.com/20592214/120428626-47040300-c374-11eb-9d0c-864a63b4ce34.png)
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: