Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readibility issue #3

Closed
black7375 opened this issue May 2, 2021 · 1 comment
Closed

Readibility issue #3

black7375 opened this issue May 2, 2021 · 1 comment
Labels
Class::Padding Padding and margin related layout Issue::Enhancement New feature or request Priority::Low The importance is low

Comments

@black7375
Copy link
Owner

https://www.reddit.com/r/firefox/comments/n2i6fg/proton_padding_fix_quantum_proton_proton_fix/gwk5ucm

For my point of view your proposition create a readibility issue as you have now a unique content block. It complicate to easily identicate different part of the menu. Space with a gray pver a gray doesn't reach contrast ration for accessibility and can be unsee for some user, and by removing the spacing you remove the section view.
- /u/mistic_me_meat
@black7375 black7375 added the Issue::Enhancement New feature or request label May 2, 2021
@black7375 black7375 added Class::Padding Padding and margin related layout good first issue Good for newcomers Priority::Low The importance is low and removed good first issue Good for newcomers labels May 27, 2021
@black7375
Copy link
Owner Author

I think it's improved a lot now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Class::Padding Padding and margin related layout Issue::Enhancement New feature or request Priority::Low The importance is low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@black7375