Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More documentation needed, please #51

Closed
2 of 9 tasks
David263 opened this issue Jun 3, 2021 · 14 comments
Closed
2 of 9 tasks

More documentation needed, please #51

David263 opened this issue Jun 3, 2021 · 14 comments
Labels
Class::Color Color, background, blur, etc. Class::Padding Padding and margin related layout Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Documentation Improvements or additions to documentation

Comments

@David263
Copy link

David263 commented Jun 3, 2021

Describe the bug
A clear and concise description of what the bug is.
Please describe how to get the "compact" menus, with smaller vertical spacing.
Expected behavior
A clear and concise description of what you expected to happen.
I expected the menus to be fixed to look like before release 89.0. They are still too spread out vertically. The toolbars look better, though.
Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • Firefox Version: [ 89.0]
  • OS:
    • Linux
    • Windows: 10 Home
    • Mac
    • Others:
  • Theme:
    • Light
    • Dark
    • Alpenglow(System: Light)
    • Alpenglow(System: Dark)
    • System Default
      • GTK Theme Name(Only Linux User): [sample] Adwaita, Adwaita-Dark, Breath, Breath-Dark

Additional context
Add any other context about the problem here.
Also, there is no background color difference between the three toolbars, hard to see. Also, the active tab is not well highlighted--my eyes are not that good.

@David263 David263 added the Issue::Bug Something isn't working label Jun 3, 2021
@black7375 black7375 added Class::Color Color, background, blur, etc. Class::Padding Padding and margin related layout Env::Windows Issues on Windows10, Windows11, unknown windows and removed Issue::Bug Something isn't working labels Jun 4, 2021
@black7375
Copy link
Owner

  1. Do you mean context menu? or hamburger menu(Panel)?

  2. How about using photon-style?
    It's easier to distinguish because there's a tab line.
    image

@David263
Copy link
Author

David263 commented Jun 4, 2021

No, I don't mean the context menu or hamburger menu. I don't know how to use photon-style because there are no instructions.

Besides, I have had to uninstall Firefox-UI-Fix because of the serious Pinned Tabs bug. I don't plan to try this fix again until it is really working well. It has been released way too early.

@black7375 black7375 added the Issue::Documentation Improvements or additions to documentation label Jun 4, 2021
@black7375
Copy link
Owner

Likewise, you can download it from the link above.

This is a beta program, not even 1.0.
There are plans to remove the pinned tab close button issue after that.

@black7375
Copy link
Owner

  1. Compact Mode
  • Go to Hamburger Menu - More Tools - Customize toolbar
  • Set Density - Compact
  1. Light Mode's contrast
    image
    Contrast is enhanced.

  2. Installation Guide
    https://github.com/black7375/Firefox-UI-Fix/wiki/Installation-Guide


Now it seems that the conditions of this issue are satisfied.

@David263
Copy link
Author

Still waiting for an answer to the original question: how to get less vertical spacing in the new menu format for Firefox. It does not make sense to use lots of whitespace for desktops and too little whitespace for mobile devices. Firefox should use the media queries of CSS to tailor its layout to the size of the client window, so the user doesn't have to jump through hoops to do basic customization of menus.

@black7375
Copy link
Owner

black7375 commented Aug 26, 2021

You can set like this

https://github.com/black7375/Firefox-UI-Fix/wiki/Tips#reduce-menu-padding

There are no plans to adopt this as a default. (To maintain design consistency and increase clickability.)

Thanks for the question,

@David263
Copy link
Author

That is very interesting but off-topic. The topic is restoring Firefox menus to their former closer vertical spacing, and ensuring that spacing adapts to the device window size. In other words, there is a bug here that needs fixing, and I don't know enough about building Firefox to pull the fix myself here at GitHub.

I don't know about others, but I just don't have the time to read this entire document, or try to make use of it to make Firefox menus more usable for myself. That is why I'm trying to get Firefox menus fixed for everyone, not just me.

@black7375
Copy link
Owner

It's actually not that wide.

Edge
image

Chrome
image

My Theme
image


It won't be that difficult for anyone with programming knowledge just to change the value.
But I understand that it is difficult for the average person.

So, it is planned to GUI installer and introduce JS to change the settings in the future roadmap.

@David263
Copy link
Author

David263 commented Aug 26, 2021

Most Firefox users cannot or do not wish to run a separate tool just to change the vertical spacing of menus back to what it was. I don't care about Chrome or Edge, just Firefox and just most users of Firefox, who are a bit afraid of computer systems.

Evidently, you're not aware that a few months ago Firefox increased the vertical spacing of its menus, probably for mobile devices. I'm asking for the use of CSS, not artificial intelligence or something that is difficult to do, and I'm asking for a bug fix, not a customization.

By the way, I stand behind my bug fix requests, in case you had some doubt. I will not be bought off by halfway measures. I ask for standard and responsive modern design for Firefox menus and layouts. I don't think that is unfair. I think Firefox users expect it to work right out of the box without need for extensive customization. Firefox users are not computer hackers like those of you who are posting here. They are people of all ages and backgrounds who just want to browse the Web.

I would appreciate some feedback from anyone here who supports my point of view about Firefox.

@black7375
Copy link
Owner

black7375 commented Aug 26, 2021

It's a bit wider than Chrome, and I'm aware of the differences from previous Firefox.
image

In my opinion, current size adjusted is well balanced, and I think the average user will be able to understand it.

According to Fitts's law, as the width increases, it becomes easier to click.
Of course, a moderate level is good, as too wide will make it difficult to access other menus.

@David263
Copy link
Author

Thank you for your research. Windows stands out as the problem. Since I use only Windows, I didn't notice that the menu evidently works well in other OSs. How to fix Windows, if CSS won't work properly? The real question is: why do Firefox menus have such large vertical spacing when run under Windows? I haven't noticed an answer in this thread.

The problem is worst with the longest menus: the tabs menu (click rightmost down arrow button), Bookmarks, History, File, Open Application Menu, More Tools, and possibly others.

Also, I'm not sure why you keep talking about width, when the original question here is about vertical spacing.

@black7375
Copy link
Owner

black7375 commented Aug 26, 2021

It's probably because:

  • Win: None native menu
  • Mac: Mac's native menu
  • Linux: Follow system GTK's style

Tab menu has a lot of space.
I agree to a certain extent.

I was omitting height's wide as wide.
Please understand that it is not English native but a little clumsy.

@David263
Copy link
Author

David263 commented Aug 26, 2021

No problem. In English, we use "wide" or "width" only to mean the x direction, also called horizontal. We use "height" or "high" to mean the y direction, also called vertical. English is quite hard because it imports words from many other languages.

If Firefox generates menus only in Windows, then my above remarks about CSS are relevant to this bug fix. Firefox should use the proper CSS when generating the menus.

@black7375
Copy link
Owner

Yes, I'll consider it in the future update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class::Color Color, background, blur, etc. Class::Padding Padding and margin related layout Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants