Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address bar highlight is missing in dark mode on macOS #851

Closed
3 of 9 tasks
Anton2319 opened this issue Dec 21, 2023 · 1 comment
Closed
3 of 9 tasks

Address bar highlight is missing in dark mode on macOS #851

Anton2319 opened this issue Dec 21, 2023 · 1 comment
Labels
Browser::Upstream Changes or bugs from Firefox Class::Color Color, background, blur, etc. Component::Toolbar Toolbar or navbar Distribution::Photon-Style Photon style distribution related Env::Mac Issues on Mac Issue::Bug Something isn't working

Comments

@Anton2319
Copy link

Anton2319 commented Dec 21, 2023 •
edited

Describe the bug

If the address bar is not selected, it is not highlighted in dark mode, starting with Firefox 121 on macOS with dark mode enabled. Bug does not seem to exist on Firefox 120 or in a light mode. The original (unmodified) firefox distribution does not have that bug either. I am running macOS 13.6.3 with the latest updates.

Expected behavior

I grew accustomed to the aforementioned highlighting because it helps me with my visual memory

Screenshots

Screenshot 2023-12-21 at 1 27 50 AM Screenshot 2023-12-21 at 1 27 45 AM Screenshot 2023-12-21 at 1 27 37 AM Screenshot 2023-12-21 at 1 27 29 AM

OS

Mac OS

OS - Others

No response

Firefox Version

v121.0

Distribution

Theme

Theme - More Info

No response

user.js setup

Default settings

Additional context

No response
@Anton2319 Anton2319 added the Issue::Bug Something isn't working label Dec 21, 2023
@black7375 black7375 added Env::Mac Issues on Mac Class::Color Color, background, blur, etc. Component::Tabbar Tab or tabbar Distribution::Photon-Style Photon style distribution related Browser::Upstream Changes or bugs from Firefox Component::Toolbar Toolbar or navbar and removed Component::Tabbar Tab or tabbar labels Jan 6, 2024
black7375 added a commit that referenced this issue Jan 7, 2024
@black7375
Fix: Theme - Mac background field color #851
350f20e 
mozilla/gecko-dev@ff5ed15
mozilla/gecko-dev@b21a492
@black7375
Copy link
Owner

Thanks. Now it looks like this:
image

This is caused by Mozilla removing the color.
mozilla/gecko-dev@b21a492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Browser::Upstream Changes or bugs from Firefox Class::Color Color, background, blur, etc. Component::Toolbar Toolbar or navbar Distribution::Photon-Style Photon style distribution related Env::Mac Issues on Mac Issue::Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@black7375 @Anton2319