Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing icons on menu bar context menu (Copy Without Site Tracking, Paste and Go) #873

Closed
1 of 9 tasks
happy-dude opened this issue Feb 20, 2024 · 3 comments
Closed
1 of 9 tasks
Labels
Class::Icon Icon for panels, menus, libraries Component::Context-Menu Only for context menu Issue::Bug Something isn't working

Comments

@happy-dude
Copy link

Describe the bug

After copying a link and right clicking the menu bar, two options lack corresponding icons:

  • Copy Without Site Tracking
  • Paste and Go

Expected behavior

Icons appears for the menu-bar-right-click context menu:

  • Copy Without Site Tracking
  • Paste and Go

Copy Without Site Tracking reuses the same icon from right-clicking a link in a web page

Screenshots

Right clicking the menu bar after copying a link:
Screenshot from 2024-02-20 17-38-42

Right clicking a link on a webpage showing an existing Copy Without Site Tracking icon:
Screenshot from 2024-02-20 17-42-19

OS

Linux

OS - Others

No response

Firefox Version

125.0a1 20240220094730

Distribution

Theme

Theme - More Info

Yaru-dark

user.js setup

user.js setup
// Your settings

Additional context

Application Basics
Name Firefox
Version 125.0a1
Build ID 20240220094730
Distribution ID mozilla-deb
Update Channel nightly
User Agent Mozilla/5.0 (X11; Linux x86_64; rv:125.0) Gecko/20100101 Firefox/125.0
OS Linux 6.5.0-1014-oem #15-Ubuntu SMP PREEMPT_DYNAMIC Fri Jan 19 11:03:48 UTC 2024
OS Theme Yaru-dark / Yaru
Application Binary /usr/lib/firefox-nightly/firefox-bin

@happy-dude happy-dude added the Issue::Bug Something isn't working label Feb 20, 2024
@happy-dude happy-dude changed the title Missing icons on menu bar context menu (Copy Without Site Tracking, Paste and Go Missing icons on menu bar context menu (Copy Without Site Tracking, Paste and Go) Feb 20, 2024
@happy-dude
Copy link
Author

I was looking through the code to try and understand what was happening -- perhaps it is found in this file?

#urlbar-input-container .textbox-contextmenu menuitem[cmd="cmd_redo"] {
@include Option("userChrome.icon.menu.full") {
--menuitem-image: url("../icons/redo.svg");
}
}
#urlbar-input-container .textbox-contextmenu menuitem[cmd="cmd_cut"] {
--menuitem-image: url("../icons/edit-cut.svg");
}
#urlbar-input-container .textbox-contextmenu menuitem[cmd="cmd_copy"] {
--menuitem-image: url("../icons/edit-copy.svg");
}
#strip-on-share {
@include Option("userChrome.icon.menu.full") {
--menuitem-image: url("../icons/link-no-tracking.svg");
}
}

What can I do to debug further (and maybe contribute a PR)?

@black7375 black7375 added Class::Icon Icon for panels, menus, libraries Component::Context-Menu Only for context menu labels Feb 24, 2024
@black7375
Copy link
Owner

black7375 commented Feb 24, 2024

Yes. If you enable userChrome.icon.menu.full as true with about:config, you can have a menu with most of the icons.

image

@happy-dude
Copy link
Author

Ah, thanks for pointing out that setting! This is probably expected behavior then; I'll close this ticket :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class::Icon Icon for panels, menus, libraries Component::Context-Menu Only for context menu Issue::Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants