Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup broken in upcoming Plasma 5.26 #109

Closed
thelaughinggnome opened this issue Sep 10, 2022 · 10 comments
Closed

Popup broken in upcoming Plasma 5.26 #109

thelaughinggnome opened this issue Sep 10, 2022 · 10 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@thelaughinggnome
Copy link

Plasma applet popups are now resizable, but need to be updated for this new functionality. The graph is currently very broken.

See: https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/500 and https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1688

Screenshot_20220911_011039

@galibozek
Copy link
Contributor

galibozek commented Oct 11, 2022

I confirm the problem, the stable Plasma 5.26 was released today. It is not possible to resize the widget and default width and height is too small :/

@galibozek
Copy link
Contributor

@blackadderkate is it possible to set default width and height?

@idamir
Copy link
Contributor

idamir commented Oct 13, 2022

At least Layout.minimumWidth and Layout.minimumHeight should be set like
Layout.minimumWidth: PlasmaCore.Units.gridUnit * 22
Layout.maximumWidth: PlasmaCore.Units.gridUnit * 80
Layout.minimumHeight: PlasmaCore.Units.gridUnit * 22
Layout.maximumHeight: PlasmaCore.Units.gridUnit * 40
The numeric constants must be found before.

@galibozek
Copy link
Contributor

galibozek commented Oct 13, 2022

@idamir can you make a patch?

@FSKMTM
Copy link

FSKMTM commented Oct 13, 2022

Changing "width" and "height" to "implicitWidth" and "implicitHeight" in lines 39 and 40 of "FullRepresentation.qml" scales the popup properly. Doesn't make it resizable, though.

@galibozek
Copy link
Contributor

@FSKMTM thanks, it works :)

@idamir
Copy link
Contributor

idamir commented Oct 13, 2022

pr #113

@blackadderkate
Copy link
Owner

Thanks @idamir & @FSKMTM for looking into this for me.

I haven't managed to upgrade my ArchLinux development box to Plasma 5.26 yet - been busy with work and family issues. I'm hoping to get it upgraded on Saturday, so I can work on making the widget properly resizeable.

@blackadderkate blackadderkate self-assigned this Oct 13, 2022
@blackadderkate blackadderkate added bug Something isn't working enhancement New feature or request labels Oct 13, 2022
@fkru
Copy link

fkru commented Oct 15, 2022

@blackadderkate: After upgrading to KDE Plasma 5.26 I am also hit by this bug. The fix should reach KDE Store (https://store.kde.org/p/1683743) as well, since there are lots of people not updating via github. Thx.

@blackadderkate
Copy link
Owner

@blackadderkate: After upgrading to KDE Plasma 5.26 I am also hit by this bug. The fix should reach KDE Store (https://store.kde.org/p/1683743) as well, since there are lots of people not updating via github. Thx.

Don't worry, I'll be releasing a new version soon! You guys here on Github are my unofficial "Beta" testers - once you've found all the bugs I've missed then I upload a new version to the KDE store!

To be honest, I think I've got most of them squashed now, so I'll be uploading a new version there soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants