This repository has been archived by the owner on Oct 9, 2018. It is now read-only.
application menu update #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Rory, Any chance you can reduce the pull request to just the files in the src/ directory.. It makes it a lot easier to merge in |
|
👍 Should be what you need now. I forgot that with the new build process this is the easiest way for you :) |
tneil
pushed a commit
that referenced
this pull request
Mar 25, 2013
|
I've also opened up issue #762 for a drawing artifact that I found |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code to fixes #379
Menu now behaves properly on BB10 devices, and PlayBook with the BB10 flag. It still has original behaviour for PlayBook without the BB10 flag.
I believe it behaves and looks as specified in the UI/UX document.
There are now options for:
data-bb-pin="right" - pulls this icon to the far right
data-bb-pin="left" - pulls this icon to the far left
Both of these grab the first item specified, subsequent items are treated as normal items. They are there to make it easier to place help and settings menu.
swipedown/onswipe menu is now disabled if Tab Overflow or CCM are displaying.