Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hanging Note Releases #34

Open
maxwellmattryan opened this issue May 3, 2021 · 0 comments
Open

Hanging Note Releases #34

maxwellmattryan opened this issue May 3, 2021 · 0 comments
Assignees

Comments

@maxwellmattryan
Copy link
Collaborator

maxwellmattryan commented May 3, 2021

Summary

At times, the notes hang indefinitely after releasing a note. It doesn't consistently do this across patches or even sometimes across notes played within the same patch.

System Info

Windows / MacOS

Notes

The behavior occurs when both the envelope generator's (EG) sustain parameter is set lower (lower = more intense hanging, i.e. -60dB is the worst while 0.0dB has no hanging) and the user plays a quick note. This helps to narrow down the cause of this issue because I suspect that playing quick notes results in some funkiness being caused in the renderNextBlock(...) method. While still not entirely clear, this is a good starting point.

If the sustain is set to -60.0dB, so long as the user releases the note before the decay duration is over then it will repeat whatever value is there indefinitely. If the user holds the note for long enough, the EG acts as normal. If the sustain is set to 0.0dB, there are no problems with this.

@maxwellmattryan maxwellmattryan self-assigned this May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant