Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain 'uniqueTokenPerInterval' #1109

Open
zatziky opened this issue Jan 15, 2021 · 2 comments
Open

Explain 'uniqueTokenPerInterval' #1109

zatziky opened this issue Jan 15, 2021 · 2 comments

Comments

@zatziky
Copy link

zatziky commented Jan 15, 2021

Hello,

the API of your lib looks really simple.
Yet, I struggle to understand uniqueTokenPerInterval.
Can you please add an example to the documentation?

@simlu
Copy link
Collaborator

simlu commented Jan 15, 2021

Hello 👋

Yeah, that could probably be documented better.

Lets say you are using ip addresses to rate limit. This value is then the amount of different ip addresses the specific lambda container could see in the interval before it would start forgetting rate limits for the first ip addresses it has seen in the interval.

It is only really relevant if you use long interval windows and have a lot of different rate limit tokens aka users.

Does that make sense?

@zatziky
Copy link
Author

zatziky commented Jan 18, 2021

@simlu Hey Lukas,

it makes complete sense. 👌 Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants