-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimization #166
Comments
Consider using |
Also consider caching |
More things to consider:
|
Performance test: import fs from 'smart-fs';
import objectScan from './src/index.js';
const data = fs.smartRead('./test/integration/entities.json');
const scanner = objectScan(['**'], { joined: false });
const repeats = 1;
for (let i = 0; i < repeats; i += 1) {
console.time('scan');
const count = 1000;
for (let idx = 0; idx < count; idx += 1) {
scanner(data);
}
console.timeEnd('scan');
} |
Need to further investigate GC overhead as it seems excessive. Asked for further instructions here |
This library is highly optimized now. However meta computation can still be a significant overhead. Creating a separate ticket for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now that meta computation gotten more expensive it should only be computed once. However computation should still only happen on demand.
The text was updated successfully, but these errors were encountered: