Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor marginal_latent_gaussian.py so it is PyTree compatible #237

Open
rlouf opened this issue Jun 29, 2022 · 1 comment
Open

Refactor marginal_latent_gaussian.py so it is PyTree compatible #237

rlouf opened this issue Jun 29, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers important refactoring Change that adds no functionality but improves code quality
Milestone
1.0

Comments

@rlouf
Copy link
Member

rlouf commented Jun 29, 2022

The library has a history of not entirely working with PyTrees, see #216 for instance. We should make sure that it does (adding tests) before the first stable release.
@rlouf rlouf added this to the 1.0 milestone Jun 29, 2022
@rlouf rlouf added enhancement New feature or request refactoring Change that adds no functionality but improves code quality labels Jul 12, 2022
@rlouf
Copy link
Member Author

rlouf commented Jan 18, 2023

As discussed in #441 this primarily involves refactoring mgrad. We need some sort of resolution on #77 as well.

@albcab albcab mentioned this issue Mar 10, 2023
Closed
@junpenglao junpenglao reopened this Oct 29, 2023
@junpenglao junpenglao changed the title Make sure that the support for PyTrees is complete Refactor marginal_latent_gaussian.py so it is PyTree compatible Oct 29, 2023
@junpenglao junpenglao added the good first issue Good for newcomers label Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers important refactoring Change that adds no functionality but improves code quality
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@rlouf @junpenglao