You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After these changes we can no longer upgrade to the next versions of this library, and I wonder if this change can be reverted or fixed in a compatible manner, and if the gem is going to adhere the SemVer after that.
The text was updated successfully, but these errors were encountered:
https://github.com/blacklane/kiev/pull/16/files#diff-273d270ab40b3f1f156b1f421527a7bfdae610104b3d5edcf2feee6cd4585959R62
Here the code assumes that the status has
to_i
method, which wasn't assumed before. Usage ofto_i
works only for HTTP log entry and breaks the logging completely in our case for some background jobs. Moreover, it was correctly pointed out during the review, but was ignored and merged without resolving the discussion.After these changes we can no longer upgrade to the next versions of this library, and I wonder if this change can be reverted or fixed in a compatible manner, and if the gem is going to adhere the SemVer after that.
The text was updated successfully, but these errors were encountered: