Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.3.0 Introduced backward-incompatible changes in minor version #17

Open
hwo411 opened this issue Nov 3, 2020 · 0 comments
Open

v4.3.0 Introduced backward-incompatible changes in minor version #17

hwo411 opened this issue Nov 3, 2020 · 0 comments

Comments

@hwo411
Copy link

hwo411 commented Nov 3, 2020

https://github.com/blacklane/kiev/pull/16/files#diff-273d270ab40b3f1f156b1f421527a7bfdae610104b3d5edcf2feee6cd4585959R62
Here the code assumes that the status has to_i method, which wasn't assumed before. Usage of to_i works only for HTTP log entry and breaks the logging completely in our case for some background jobs. Moreover, it was correctly pointed out during the review, but was ignored and merged without resolving the discussion.

After these changes we can no longer upgrade to the next versions of this library, and I wonder if this change can be reverted or fixed in a compatible manner, and if the gem is going to adhere the SemVer after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant