Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TextTheme.body1 was replaced by bodyText1 as it failed in newer versions #53

Closed
wants to merge 5 commits into from

Conversation

nombrekeff
Copy link

Hey there!

I use this plugin on a project at work, we just updated Flutter, and the build failed because of invalid TextTheme property body1.

Description

Replaces TextTheme.body1 with TextTheme.bodyText1

PD: Are you maintaining the project? or would I be able to help out? Otherwise is there any problem in me making a clone so I can maintain it for work?

@nombrekeff
Copy link
Author

Sorry, pubspec.lock was uploaded on error, I will remove it

@nombrekeff
Copy link
Author

It's not yet working, dependency issues, I will do some tests and let you know when I find the solution.

@nombrekeff
Copy link
Author

It's not yet working, dependency issues, I will do some tests and let you know when I find the solution.

Okay, I've tested and this works with Flutter v2.4.0

@blackmann
Copy link
Owner

Hello, thanks for the contribution. Could you please compare to the null safety branch instead?
@nombrekeff

@nombrekeff
Copy link
Author

nombrekeff commented Jul 28, 2021

Ohh sure, I did not know there was one!

@nombrekeff nombrekeff changed the base branch from master to nullsafety July 28, 2021 09:56
@blackmann blackmann closed this Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants