Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sbadmin v2] Nav bar and top nav bar active state #64

Closed
antonioribeiro opened this issue Jul 1, 2014 · 3 comments
Closed

[sbadmin v2] Nav bar and top nav bar active state #64

antonioribeiro opened this issue Jul 1, 2014 · 3 comments

Comments

@antonioribeiro
Copy link

Is the active state supposed to work like on Bootstrap?

<ul class="nav navbar-top-links navbar-right">
    <li class="active">
        <a href="#">1 day</a>
    </li>
</ul>
@davidzchen
Copy link

I noticed this too. The active state doesn't seem to be working because the <ul> does not have the navbar-nav class. Adding it makes the active state work but changes the colors of all the links in the navbar.

Perhaps the sbadmin v2 CSS should override navbar-nav class to also set the colors of links as well.

@antonioribeiro
Copy link
Author

@davidzchen, it works as you said, and, at least in my case, it's better than not having it. Link colors won't be a problem, thanks.

But the same doesn't work for the sidebar. Probably also a missing class, but since I'm not really a bootstrap expert, I could not solve that one myself. Or those <li> wasn't supposed to have an "active" class?

@BlackrockDigital
Copy link
Collaborator

The sidebar in SB Admin 2 doesn't have default active classes built in. The reason for this is that a plugin is being used for the menu which requires custom CSS styles. An active class will be available in the next update of the theme!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants