CSS Minification Incompatibility within SB Admin 2 (and possibly elsewhere)

[evantishuk]

I am pumping SB Admin 2 through CSSMin (https://code.google.com/p/cssmin/) within my asset manager, and it breaks on the media queries (ex: https://github.com/IronSummitMedia/startbootstrap/blob/gh-pages/templates/sb-admin-2/css/sb-admin-2.css#L21) thereby borking everything downstream.

The solution I came up with was to convert this:

@media(min-width:768px) { ... }

to the more verbose, but equivalent:

@media all and (min-width:768px) { ... }

I'd be happy to make a pull request, or help adapt this to other areas of the library.

[davidtmiller]

Thanks for pointing this one out. I am getting ready to restructure a lot of the templates and push them into their own repos, so it won't be necessary to make pull requests yet. Once I've moved all of the templates to their own repo it will be easier to manage each template on an individual level. Thanks for pointing this out though, I'll get it fixed in the next update!

[evantishuk]

Cool.

Another thing that could be explored is making use of Bootstrap's container width variables (https://github.com/twbs/bootstrap/blob/master/less/variables.less#L326) in places like https://github.com/IronSummitMedia/startbootstrap/blob/gh-pages/templates/sb-admin-2/less/sb-admin-2.less#L22

Also, it's totally selfish, but a port to Sass that extends https://github.com/twbs/bootstrap-sass would be pretty rad too :)

Thanks.