Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider conforming to the WordPress Coding Standards #38

Closed
zachwills opened this issue Oct 25, 2016 · 7 comments
Closed

Consider conforming to the WordPress Coding Standards #38

zachwills opened this issue Oct 25, 2016 · 7 comments

Comments

@zachwills
Copy link
Contributor

Since this is a WordPress plugin it might make sense to conform to the WPCS.

You can add PHPCS and PHPCBF integration so you can run reports to see what lines aren't matching the standard, and PHPCBF will automatically fix some of the issues found (the ones that can be fixed).

@blackus3r
Copy link
Owner

This would be nice, I will have a look at it :-)

@blackus3r blackus3r self-assigned this Oct 25, 2016
@blackus3r
Copy link
Owner

Are you familiar with that? Can you show me, how to do that?

@zachwills
Copy link
Contributor Author

Yeah I am familiar. I can integrate it with the project in a new PR if you'd like.

@blackus3r
Copy link
Owner

That would be nice.

@zachwills
Copy link
Contributor Author

Can you add the hacktoberfest and in progress label to this?

@zachwills
Copy link
Contributor Author

@blackus3r which branch should this PR go against?

@blackus3r blackus3r modified the milestone: 1.3.0 Oct 26, 2016
@blackus3r
Copy link
Owner

Master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants