-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onParticipant{Enabled,Disabled}VideoTrack Freezes Video #165
Comments
Hm, you might be right about it being a race condition ... can you consistently reproduce the issue (e.g. if you call it twice via a setTimeout). As for whether it should be replaced with a custom component; I guess that's a product decision for you =). |
Just to chime in on this one. I am able to reproduce this fairly consistently. Reproduction steps:
Expected:
Actual
|
Has anyone tried when the other client is not using this library? Just trying to see if it's on the sender side or the receiver side. |
@slycoder - Good question. I think it is actually a Twilio issue. Just tried by spinning up two side-by-sides of this https://github.com/twilio/video-quickstart-js as was able to reproduce using a similar javascript-to-javascript use case - so its not limited to React Native. |
Simple fix for me was to listen for |
Thanks for all the deep digging @keithhackbarth and the workaround. |
@keithhackbarth Can you provide code snippet of how to show black screen on disable video? I am unable to listen to this event. |
@keithhackbarth I'm running into a similar issue and pattern of behavior, using Vue.js in this particular instance. But, same gist. Running the following code on my disable mutation leaves a paused / frozen video rather than a black screen the majority of the time:
Even their sample code for |
Hey, I was wondering were you able to find any work around on it? |
Steps to reproduce
Expected behaviour
TwilioVideoParticipantView
(which is user A)Actual behaviour
TwilioVideoParticipantView
(which is user A)I noticed that if I toggle the video on User A multiple times (calling
setLocalVideoEnabled
) fast enough, it will go to be a black screen. Is this because of how streaming works and there is a delay in when user B receives the final stream before user A shuts off their video stream?I am a newbie when it comes to how video works on Twilio. Any help would be appreciated!
Edit: Another question is, when the
onParticipantDisabledVideoTrack
is called should we be replacing theTwilioVideoParticipantView
with our own custom components?Environment
react-native-twilio-video-webrtc
Version: master
The text was updated successfully, but these errors were encountered: