Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto discover for Laravel and allow absolute paths #26

Closed
DevDavido opened this issue May 7, 2018 · 1 comment
Closed

Add auto discover for Laravel and allow absolute paths #26

DevDavido opened this issue May 7, 2018 · 1 comment

Comments

@DevDavido
Copy link

DevDavido commented May 7, 2018 •
edited

Thank you Adam for this useful package!
I started using it and I noticed it doesn't allow absolute paths for the svg_path option for example like most other packages do. I wanted to use the public_path() or storage_path() helper to define the path.
A nice bonus would be having the auto discovery functionality from Laravel too.
Would you also accept a PR for such changes?
@driesvints
Copy link
Member

Heya, auto discovery was already added in the past it seems. Using the path helpers in config files isn't possible with Laravel I'm afraid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@driesvints @DevDavido