Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListenerCompatUtil incorrectly evaluates method #1743

Closed
thecapdan opened this issue Nov 8, 2016 · 0 comments · Fixed by #1744
Closed

ListenerCompatUtil incorrectly evaluates method #1743

thecapdan opened this issue Nov 8, 2016 · 0 comments · Fixed by #1744
Assignees
Labels
Milestone

Comments

@thecapdan
Copy link
Contributor

thecapdan commented Nov 8, 2016

... evaluation is taking place in a popout and it is not identified as an instanceof Function but typeOf method returns "function".

@thecapdan thecapdan added the bug label Nov 8, 2016
thecapdan pushed a commit that referenced this issue Nov 8, 2016
@thecapdan thecapdan added this to the 1.5.5 milestone Nov 8, 2016
vmus pushed a commit to vmus/brjs that referenced this issue Mar 16, 2017
* master: (305 commits)
  adding release note for 1.5.9 release
  BladeRunnerJS#1757 ensure fixture factory teardowns are called during GWTTestRunner endTest
  correcting test names
  adding release note for 1.5.8 release
  ElementUtility bugfix for case where SVG elements are used in IE11  - adding tests
  refactor ElementUtilityTest layout in line with new coding style
  adding release notes for 1.5.7
  replace use of element.className.match with element.classList.contains to allow it to work with svg elements
  update emitr library to 0.0.9
  Revert "Add parameter to avoid error being suppressed in emitr.js"
  updating release notes for 1.5.6 with note about emitr fix
  Add parameter to avoid error being suppressed in emitr.js (BladeRunnerJS#1746)
  bugfix for locale switcher, ensures locale redirect works form root level index.html. - contains check for IE - unit test added - release note added
  adding release note for ListenerCompatUtil fix
  changing ListenerCompatUtil to use typeof when checking listener method is a function. fixes BladeRunnerJS#1743
  adding release note for jquery upgrade
  upgrading jquery to 1.12.4 and removing an unnecessary test that was testing visibility of a zero size element. BladeRunnerJS#1702
  adding release notes for version 1.5.3
  feat(br-util): Add `cancelPerformOnce` method to `Utility`
  workaround for very strange chrome bug where it would mark this perfectly ordinary operator as an unknown identifier
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants