Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron instances persist after exiting with Ctrl + C #14

Closed
paanvaannd opened this issue May 18, 2018 · 2 comments
Closed

Electron instances persist after exiting with Ctrl + C #14

paanvaannd opened this issue May 18, 2018 · 2 comments
Labels
feedback needed I implemented something but I'm not sure if it works, or I can't reproduce an error.

Comments

@paanvaannd
Copy link

I'm actually not sure if I'm doing this right... I start the app with $ npm start and to stop I exit with Ctrl + C (I'm pretty sure this sends a SIGINT) and while this stops the application and allows me to interact with my terminal again, an Electron application remains in my Dock after each run and Activity Monitor shows that same process along with an associated Electron Helper per spawned process. The only way to exit those processes is to go to Force Quit those processes.

Perhaps using this would be a good way of quitting the process completely if I'm stopping the process properly on my end? I think it would also be necessary to provide users a good way to quit the app natively before release, so maybe a "Quit" button within the Preferences pane?

@blahsd
Copy link
Owner

blahsd commented May 21, 2018

I can't reproduce the issue. I also exit with Ctrl+C, but this, for me, causes the electron processes to be killed.

Have you given it some time? It's true that the garbage collection in electron takes a bit of time – for me it's a few seconds before all of the processes disappear, but it might depend on your specific setup and how long snwe was running for

@blahsd blahsd added the feedback needed I implemented something but I'm not sure if it works, or I can't reproduce an error. label May 21, 2018
@paanvaannd
Copy link
Author

I cannot reproduce this issue any longer either... closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback needed I implemented something but I'm not sure if it works, or I can't reproduce an error.
Projects
None yet
Development

No branches or pull requests

2 participants