Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for enabling/disabling the new spatial voice feature #115

Closed
blake-mealey opened this issue Jan 19, 2022 · 3 comments · Fixed by #163
Closed

Add support for enabling/disabling the new spatial voice feature #115

blake-mealey opened this issue Jan 19, 2022 · 3 comments · Fixed by #163
Labels
missing configuration Missing support for Roblox configuration

Comments

@blake-mealey
Copy link
Owner

Config:

target:
  experience:
    configuration:
      spatialVoiceEnabled: true # defaults to `false`

This is managed via a separate API surface so it will need a new resource type under the hood:

  • Resource type: spatialVoiceConfiguration
  • Create/update: POST https://voice.roblox.com/v1/settings/universe/{experienceId}
    • JSON body { "optIn": boolean }
  • Delete: update to be disabled
  • Import: GET https://voice.roblox.com/v1/settings/universe/{experienceId}
    • JSON body { "isUniverseEnabledForVoice": boolean }

The design of the roblox API suggests to me that there will be more settings in the future for how spatial voice is configured. Until then I think this API is fine, but in the future we might refactor to something like:

target:
  experience:
    spacialVoice:
      enabled: true
      someOtherSetting: false
@blake-mealey blake-mealey added enhancement New feature or request missing configuration Missing support for Roblox configuration and removed enhancement New feature or request labels Jan 19, 2022
@blake-mealey
Copy link
Owner Author

From reading the dev forum thread about this I noticed:

We would like to announce that from today Spatial Voice is supported in places with up to 50 Max Players, previously Spatial Voice was limited to places with up to 30 Max Players.

I'm assuming this will be managed by a server-side error message which we should make sure to test for.

@blake-mealey
Copy link
Owner Author

I'd like to use the second API described above to avoid potential breaking changes if we do need to expand it in the future

@blake-mealey
Copy link
Owner Author

Although the endpoints are undocumented I noticed that there are v2 and v3 sections in the voice API service docs: https://voice.roblox.com/docs#!/v1

I got the endpoints described in the issue a long time ago and I may need to update to these newer APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing configuration Missing support for Roblox configuration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant