Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When launching a review alert/detection, apply pre/post record buffers to video clip #11158

Closed
nwish opened this issue Apr 29, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@nwish
Copy link

nwish commented Apr 29, 2024

This is for 0.14

@NickM-27 this is just a FR for what I mentioned in the discussion thread if you recall.

Currently, clicking on a review alert or detection thumbnail directs the user to the full resolution recording. However, the recording starts at the frame the object was detected on and does not apply pre/post capture buffer times. To the end user, the result is that the recording seemingly starts late, as the object is already there, and sometimes on its way out of the frame already.

I believe the buffer times should apply when launching an "event" (clicking on thumbnail), and reflect on the timeline somehow as well.

@nwish nwish added the enhancement New feature or request label Apr 29, 2024
@NickM-27
Copy link
Sponsor Collaborator

Thanks, this was implemented in #11143

@nwish
Copy link
Author

nwish commented Apr 29, 2024

Thanks, this was implemented in #11143

Whoops, didn't even see that, sorry!

@nwish
Copy link
Author

nwish commented Apr 29, 2024

Actually hey @NickM-27 I just tested this and it looks like the buffers apply when launching from the main review area, but when launching an event from within a camera history view, the buffers do not apply.

@NickM-27
Copy link
Sponsor Collaborator

To be clear you mean pressing an event in the filmstrip or pressing the segment in the timeline?

@nwish
Copy link
Author

nwish commented Apr 29, 2024

Filmstrip. It appears that pressing the bottom of the timeline segment will start the recording at the beginning of the buffer,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants