Update last seen id after yielding the whole batch #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged and pushed to pypi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
After further investigation I found out that it's very handy to know if an event comes from the very first batch. Such events must be ignored because they are historical data, clients usually need only newer events.
In order to achieve it I moved the assignment of the
_last_seen_idafter yielding the whole batch and exposed it as a property. Now it's possible to use the same approach as the official gui does: https://github.com/syncthing/syncthing/blob/main/gui/default/syncthing/core/eventService.js#L22Thank you!
UPD: Catch one more timeout exception