Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated function calls #9

Closed
espottesmith opened this issue Nov 10, 2020 · 3 comments
Closed

Remove deprecated function calls #9

espottesmith opened this issue Nov 10, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@espottesmith
Copy link
Collaborator

A recent PR changed several function names in mol_entry.py for the MoleculeEntry class. This inlcudes:

free_energy -> get_free_energy
Nbonds -> num_bonds
edges -> bonds

These are currently causing an aggressive quantity of deprecation warnings, which makes reading output difficult. It would be immensely helpful if someone would go through and change these outdated function calls throughout the repo.

@espottesmith espottesmith added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Nov 10, 2020
@mjwen
Copy link
Collaborator

mjwen commented Nov 11, 2020

I can do it.

In the previous PR, I did not do it because a lot of tests rely on these. So, I still hope somebody can rewrite the tests before doing this (I am not super familiar with UnitTest and do not want to deal with it).

Also, I will probably make modifications to mol_entry to make the input energy, enthalpy, entropy be of units eV, instead of the present ones. And some other TODOs I left there.

But, if we do not care too much about the current tests and allow it to fail (since we are making huge changes), I can do it right away.

@mjwen
Copy link
Collaborator

mjwen commented Nov 11, 2020

Well, looking at the PR I just made, I realize that the tests will definitely fail since MoleculeEntry used to be in pymatgen. So, I guess I will do it right away.

@espottesmith
Copy link
Collaborator Author

I'm happy to lead the charge on converting from unittest to pytest. I just want to wait until all of the tests pass before doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants