Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to disable generated Waystone drops (fixes #156) #183

Merged
merged 1 commit into from Oct 5, 2019

Conversation

@WesCook
Copy link
Contributor

WesCook commented Oct 5, 2019

I thought this'd be a pretty simple feature, but it turned out to have some surprises. Namely that it wasn't possible to get the waystone's true TE when harvestBlock was fired. If you mined the top half, the passed-in TE contained false information.

I came up with a small workaround. We essentially update the top half during an early phase of the breaking to give it the correct information. The code comments explain it in more detail.

@blay09

This comment has been minimized.

Copy link
Owner

blay09 commented Oct 5, 2019

Ideally the proper info would be set for the dummy TE during placement too, but since all these issues will probably solve themselves with the 1.14 cleanup this is fine for a workaround until then.

@blay09 blay09 merged commit f197d56 into blay09:1.12 Oct 5, 2019
@WesCook

This comment has been minimized.

Copy link
Contributor Author

WesCook commented Oct 5, 2019

Yep I considered just updating it all on creation too. I thought for a PR this would be a little less aggressive of a solution though. Plus I didn't understand the reason for the dummy TE, so I didn't want to mess too much with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.