-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent vertical scrolling when actively dragging the slider #46
Comments
Yes, I finished implementing it, was happy about just everything and then noticed this weird behavior, as you grab it and try to scroll vertical it starts scrolling horizontal but gets like 2-3 FPS while scrolling left-right together with document scrolling up-down, finally getting [Intervention] error Did you manage to fix it somehow? |
Sadly not, i have replaced the slider with a different one for the time being. |
I have the same issue. @MananTank Do you have an idea how to fix that issue? I think we'd need a check if it's actually an horizontal swipe or a vertical scroll motion / swipe on mobile. Because this seems to break the entire thing on mobile devices. Maybe I'll give it a shot later and put in a pr. |
When scrolling horizontally, vertical scrolling is disabled. But when scrolling vertically, horizontal is still possible. This leads to some weird scroll behavior on mobile devices as it can be seen in the video below.
Also, when doing this you get following error in console:
[Intervention] Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.
I first demonstrate the vertical scroll locking and afterwards the possible bug:
screen-capture.webm
The text was updated successfully, but these errors were encountered: