Pass the serialization format as a mimetype #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @llllllllll |
| @@ -130,8 +143,9 @@ def compute_down(expr, ec, **kwargs): | |||
| serial = ec.serial | |||
| r = post( | |||
| ec, | |||
| 'compute.{serial}'.format(serial=serial.name), | |||
| '/compute', | |||
There was a problem hiding this comment.
this will generate 2 slashes. we might want to update the _request function to not add the slash.
| try: | ||
| serial = _get_format(serial_format) | ||
| serial = _get_format(*mimetype_regex.match(content_type).groups()) |
There was a problem hiding this comment.
The * makes me think that this could possibly be more than one value; could we just take [0] instead?
|
Just one comment, but looks good |
| try: | ||
| serial = _get_format(serial_format) | ||
| serial = _get_format(mimetype_regex.match(content_type).groups()[0]) |
There was a problem hiding this comment.
actually, this needs to check that match is not none before taking groups()[0] or we get 500 instead of 415
There was a problem hiding this comment.
if None should that also be a 415?
There was a problem hiding this comment.
Yeah, None means we don't know what the media type is; however, a keyerror means we know what it is but this particular server doesn't use that format
cpcloud
added a commit
that referenced
this pull request
Jul 14, 2015
Pass the serialization format as a mimetype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the serialization format json, msgpack, etc is now passed as a vendor specific mime type instead of being part of the URL: