BUG: fix len for interactive exprs that wrap sql #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def test_interactive_len(sql): | ||
| t = Data(sql) | ||
| assert len(t) == odo(t.count(), int) |
There was a problem hiding this comment.
You can actually just call int(t.count()), but up to you
There was a problem hiding this comment.
oh, I didn't realize __int__ was the same. I like the clarity of odo here; however, I don't mind promoting this pattern.
|
@llllllllll Merge when ready |
|
I only needed to resolve the whatsnew but I rebased so I will let this pass before merging. |
|
cool |
cpcloud
added a commit
that referenced
this pull request
Oct 13, 2015
BUG: fix len for interactive exprs that wrap sql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
computefor the sqlbackend would return aselect. thelenmachinery would then try to coerce this into anintand fail with a type error.