-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add empty __slots__ to Expr and Node classes. #1274
Conversation
Hm it'd be great to have a test. Maybe something as simple as
|
When you're ready to merge please also add a tiny release note blurb to |
I agree a test would be good, but it feels strange to test an internal detail like "does this class have an empty |
Yes that test is definitely a bit awkward. If there's a way to test it using the user facing API, by all means |
Should that be |
Sorry I meant 0.9.0. I've moved the version to a new minor version since we're dropping support for things. |
@kwmsmith merge master back into your branch it should be passing now |
Add empty __slots__ to Expr and Node classes.
See issue #1268.
Consistently uses
__slots__
in class hierarchies, even when empty.