Weakmemoize and cleanup #1319
Merged
Weakmemoize and cleanup #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llllllllll
force-pushed
the
weakmemoize
branch
from
61e5e62
to
1b6b4ca
Compare
llllllllll
force-pushed
the
weakmemoize
branch
from
1f179a8
to
d81466c
Compare
|
tests are failing because of: #1320 |
|
@llllllllll can you restart this build |
|
sure, let me rebase away the conflicts too |
|
@llllllllll don't rebase yet! i'm reviewing |
|
oh, sorry. I will hold off on that. |
|
@llllllllll I'm done reviewing if you want to rebase |
added 7 commits
November 24, 2015 12:28
|
you need to either rebase on top of master or merge it in and resolve the conflicts as well as get the change that fixes the failing test |
llllllllll
force-pushed
the
weakmemoize
branch
from
d81466c
to
b718685
Compare
|
Added a section in the docs on adding new expressions where I cover the |
llllllllll
force-pushed
the
weakmemoize
branch
from
e6a72cc
to
c3bf874
Compare
Memory addresses will always be different.
|
@llllllllll thanks! |
|
no, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the leak that we talked about and makes all of the expressions cache their dshape and schema methods.
Also some general cleanup that I saw while making the mostly mechanical changes.