Change the like API to behave like a predicate #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olean array-likes so update the implementation accordingly
|
@llllllllll @cowlicks any comments here? |
|
@llllllllll @cowlicks probably going to merge this soon |
| @@ -267,7 +267,9 @@ def compute_up(t, x, **kwargs): | |||
|
|
|||
| @dispatch(Selection, np.ndarray) | |||
| def compute_up(sel, x, **kwargs): | |||
| return x[compute(sel.predicate, {sel._child: x})] | |||
| predicate = compute(sel.predicate, {sel._child: x}) | |||
| cond = getattr(predicate, 'values', predicate) | |||
There was a problem hiding this comment.
Why would this become a series?
There was a problem hiding this comment.
Because the like operation is done in the pandas backend
There was a problem hiding this comment.
I am trying to find where the ndarray gets coerced into a series for the Like to dispatch properly
There was a problem hiding this comment.
There was a problem hiding this comment.
I didn't realize numpy fell back to pandas. This makes much more sense, thanks
|
merging on pass |
cpcloud
added a commit
that referenced
this pull request
Dec 4, 2015
Change the like API to behave like a predicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1333