BUG: fix the weakkeydict key errors #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1: besides fixing the issue, it simplifies the code -- I'm always rusty on weak refs, and when combining weakkeydicts with caching / memoization, the complexity was making other bugfixes difficult. LGTM. |
kwmsmith
added a commit
that referenced
this pull request
Jan 26, 2016
BUG: fix the weakkeydict key errors
|
They, the only reason I normally prefer the weakkeydict approach is that the descriptor can be general because you don't need to know the name of the attribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have gotten a bunch of magical mysterious weakkeydict errors. This just uses a non data descriptor instead and replaces the
dshapeattribute on instance to get the same caching. This removes any strange cache issues and should be faster.This change is taken from: #1348 but this particular bug is causing me a lot of problems so I am submitting it as its own change.