Error checking when adding to blaze server. #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _get_auth.cache[app] = ( | ||
| _get_option('authorization', options, None) or (lambda a: True) | ||
| ) | ||
| _get_format.cache[app] = dict((f.name, f) for f in _get_option('formats', options)) |
There was a problem hiding this comment.
this should probably be a dict comprehension now
|
It is hard to see what actually changed here, could you split this into two commits? |
|
Also, since this is mainly a style change, I would like to say that I don't find |
| resp = empty_server.post('/add', | ||
| headers=mimetype(serial), | ||
| data=payload) | ||
| assert resp.status_code == 409 # CONFLICT |
There was a problem hiding this comment.
are these error codes not defined somewhere, and if not, should we make a small namespace for them like: rc.CONFLICT
kwmsmith
force-pushed
the
bugfix/blaze-server-add-errors
branch
from
ea78b32
to
1a7fda0
Compare
|
@llllllllll I split the commit up; 1a7fda0 is the core of the bugfixes, while 80da240 is the style and indentation fixup. |
|
|
||
| @pytest.mark.parametrize('serial', all_formats) | ||
| def test_add_data_twice_error(empty_server, serial): | ||
| with temp_server(): |
There was a problem hiding this comment.
should this be a pytest.yield_fixture?
Refactor redundant code and cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does basic error checking when adding a new data set to a blaze server (
/addendpoint):discoverable to verify the data is loadable and queryable;I also reformatted the indentation in other tests for consistency.