Store filenames

[maxhutch]

Filenames are stored along with keys, making old chests more portable. _keys, which was a set, is replaced with a {key -> filename} dictionary. The dictionary is dumped/loaded as a list of tuples for json compatibility, but used as a dict internally.

[mrocklin]

The old version is probably best in my_dict actually checks for membership in the keys. Adding the .keys() method creates an explicit list.

[mrocklin]

I'm not entirely sure what's happening with the file not found issue (though I also haven't looked very deeply into it). During garbage collection (__del__ call) we drop the chest. Some file seems to be missing. Perhaps we're trying to delete a file that isn't written or deleting a file twice?

[mrocklin]

I suspect that the coverage error in Python3 might be my fault. I think it's in master.

[mrocklin]

I'll take a look at that error in the next day or so. Happy to merge this with this error.

[mrocklin]

Happy to merge. Was there any behavior you wanted to test to make sure that there isn't a regression in the future? Currently there is nothing stopping someone else from coming along and unknowingly changing things back.

[maxhutch]

Good call. I wonder why that with self.lock() line keeps failing coveralls...

[mrocklin]

It's never being triggered by any of the tests. I'm investigating that this afternoon.

[maxhutch]

Its non-deterministic. On my local machine:

maxhutch@edoras:~/src/chest$ ~/anaconda3/bin/coverage run --source=chest --omit=chest/tests/test* ~/anaconda3/bin/nosetests --with-doctest 
...
Ran 33 tests in 0.405s

OK
maxhutch@edoras:~/src/chest$ ~/anaconda3/bin/coverage report
Name             Stmts   Miss  Cover
------------------------------------
chest/__init__       2      0   100%
chest/core         168      0   100%
chest/utils          6      0   100%
------------------------------------
TOTAL              176      0   100%
maxhutch@edoras:~/src/chest$ ~/anaconda3/bin/coverage run --source=chest --omit=chest/tests/test* ~/anaconda3/bin/nosetests --with-doctest 
...
Ran 33 tests in 0.408s

OK
maxhutch@edoras:~/src/chest$ ~/anaconda3/bin/coverage report
Name             Stmts   Miss  Cover
------------------------------------
chest/__init__       2      0   100%
chest/core         168      1    99%
chest/utils          6      0   100%
------------------------------------
TOTAL              176      1    99%