Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Missing Dependency on System.Text.Json #72

Closed
Siphonophora opened this issue Apr 24, 2020 · 2 comments
Closed

[Bug] Missing Dependency on System.Text.Json #72

Siphonophora opened this issue Apr 24, 2020 · 2 comments
Labels
Bug Something isn't working Resolved: Won't Fix The reported behaviour will not be changed.

Comments

@Siphonophora
Copy link

Describe the bug
Either the docs or the nuget package, is missing a dependency on System.Text.Json. The app will crash if I don't add the nuget package manually.

To Reproduce
Steps to reproduce the behavior:

  1. Create new blazor server template.
  2. Follow steps on docs to get setup and set a value in local storage. Btw, the docs still have the @function directive instead of @code
  3. You get an error as soon as the first call to local storage happens.

Expected behavior
Preferably, this package should pull in System.Text.Json automatically.

Hosting Model (is this issue happening with a certain hosting model?):

  • Blazor Server
@Siphonophora Siphonophora added Bug Something isn't working Triage Issue needs to be triaged labels Apr 24, 2020
@chrissainty
Copy link
Member

Hi @Siphonophora, thanks for spotting the issue in the readme, I've now updated it.

In terms of the dependency issue, I can't replicate it. I've created a new Blazor Server app and copied the instructions exactly as they are written in the readme and everything worked as expected. I've double-checked this on another Windows machine and on my MacBook just to make sure it wasn't something odd happening across OSs.

Could you try again and if possible on a different machine to see if this is a local issue?

@chrissainty chrissainty added Needs: More Information The author needs to provide more information on the issue. and removed Triage Issue needs to be triaged labels Apr 25, 2020
@Siphonophora
Copy link
Author

@chrissainty I tried it on my home machine and didn't get the error so I guess it was local.

Thanks for all these libraries (particularly Modal). I have been using them on some projects recently and they are all working well.

@chrissainty chrissainty added Resolved: Won't Fix The reported behaviour will not be changed. and removed Needs: More Information The author needs to provide more information on the issue. labels May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Resolved: Won't Fix The reported behaviour will not be changed.
Projects
None yet
Development

No branches or pull requests

2 participants