Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Cancellation Token support #48

Closed
Jagreaper opened this issue Jul 8, 2021 · 1 comment · Fixed by #52
Closed

[Feature Request] Cancellation Token support #48

Jagreaper opened this issue Jul 8, 2021 · 1 comment · Fixed by #52
Labels
Feature New feature that will be added to the project

Comments

@Jagreaper
Copy link

Jagreaper commented Jul 8, 2021 •
edited

I'm was trying to create a common interface to bridge the two implementations of your LocalStorageSession and SessionStorageService. However, whilst the interface for the LocalStorageService has support for cancellation tokens in its methods, the storage service does not.

I would like to see CancellationToken support integrated with this library to bring it further into parity with the LocalStorage library.
@Jagreaper Jagreaper added Feature Request Request to add a new feature Triage Issue needs to be triaged labels Jul 8, 2021
@chrissainty
Copy link
Member

Please feel free to raise a PR for this feature.

@chrissainty chrissainty added Feature New feature that will be added to the project and removed Feature Request Request to add a new feature Triage Issue needs to be triaged labels Oct 8, 2021
@chrissainty chrissainty linked a pull request Oct 8, 2021 that will close this issue
Moved test extensions to seperate project as per local storage #52
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature New feature that will be added to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moved test extensions to seperate project as per local storage Blazored/SessionStorage
2 participants
@chrissainty @Jagreaper