Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchMethod should be IEnumerable #25

Closed
alexandrereyes opened this issue Aug 16, 2019 · 3 comments · Fixed by #31
Closed

SearchMethod should be IEnumerable #25

alexandrereyes opened this issue Aug 16, 2019 · 3 comments · Fixed by #31

Comments

@alexandrereyes
Copy link

Is there any reason that SearchMethod needs to be List ? IEnumerable is the best choice to collection parameters.

@chrissainty
Copy link
Member

Hi Alexandre, the simple answer is no. SearchMethod was typed as a List initially while prototyping and just hasn't been changed. I agree that an IEnumerable would be a better design choice. I'll look to swap it over at some point in the future.

@alexandrereyes
Copy link
Author

@chrissainty what's the impact since List<T> is IEnumerable<T>? I think there is no problem in change to IEnumerable<T>

@chrissainty
Copy link
Member

chrissainty commented Aug 19, 2019

@AlanCS I never said there was a problem, it's time. I'm very busy and this is very small and low priority change, I'll make it when I can.

But please feel free to make the change and create a PR if you would like to see it dealt with quicker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants