Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite Checker doesn't handle full-attribute overwrites after TPS-style array addition #20

Open
apocalyptech opened this issue May 21, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@apocalyptech
Copy link
Contributor

These two consecutive hotfixes, in TPS, should really trigger an overwrite warning, whereas they currently don't:

set foo bar +(baz)
set foo bar (frotz)

The main issue is that the overwrite checker basically completely discards the TPS array-add syntax, since ordinarily that's completely nondestructive. But discarding it entirely means that it can't pick up on cases like the above.

Note that if this does ever get fixed, the unit tests should probably be exapanded a bit -- for instance, if the set foo bar (frotz) above isn't a hotfix, there wouldn't be any overwrite. We do have a unit test already for this case, which is at the moment expected to fail because of this bug.

Realistically, I kind of doubt this'll ever get fixed, since that syntax is hardly used, and I don't particularly feel like digging through the overwrite code sufficiently to implement a change like this. But, I suppose we'll see.

@apocalyptech apocalyptech added the bug Something isn't working label May 21, 2023
@apocalyptech apocalyptech added the needs investigation Still need to nail down exactly what the issue is label Aug 4, 2023
@apocalyptech apocalyptech removed the needs investigation Still need to nail down exactly what the issue is label Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant