Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash upon changing OE Data settings while OE is mid-search. #50

Closed
Lilu-VA opened this issue Aug 11, 2023 · 2 comments
Closed

Crash upon changing OE Data settings while OE is mid-search. #50

Lilu-VA opened this issue Aug 11, 2023 · 2 comments
Labels
bug Something isn't working target-1.4.0 Fixed in v1.4.0

Comments

@Lilu-VA
Copy link

Lilu-VA commented Aug 11, 2023

Operating System:
Windows 11

OpenBLCMM Version: 1.3.3
Java Version: 17.0.6
Java VM: Substrate VM GraalVM 22.3.1 Java 17 CE
Memory Used: 130.3 MB
Memory Max: 13.5 GB
BL2 Data: Loaded, v2023.04.20.01
TPS Data: Loaded, v2023.04.21.01
AODK Data: Not loaded: No jarfiles found for AODK

Describe the bug
Crash upon changing OE Data settings while OE is mid-search.

To Reproduce
Change OE Data settings while OE is searching

Additional context
log-2023-08-11-085722.log

@Lilu-VA Lilu-VA added the bug Something isn't working label Aug 11, 2023
@apocalyptech apocalyptech added the target-1.4.0 Fixed in v1.4.0 label Aug 11, 2023
@apocalyptech
Copy link
Contributor

Ah, yeah, makes sense. Should be easy enough to fix up; just gotta have the looping search code make a copy of that var instead of operating on the "live" one. That way the "real" one can be changed without impacting the running search.

apocalyptech added a commit that referenced this issue Aug 11, 2023
@apocalyptech
Copy link
Contributor

Okay, this is fixed on next, will be a part of 1.4.0. Cheers, thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working target-1.4.0 Fixed in v1.4.0
Projects
None yet
Development

No branches or pull requests

2 participants