Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert StringTable to use a CSV library (or more likely, remove StringTable entirely) #6

Closed
apocalyptech opened this issue Apr 24, 2023 · 2 comments
Closed

Convert StringTable to use a CSV library (or more likely, remove StringTable entirely) #6

apocalyptech opened this issue Apr 24, 2023 · 2 comments
Labels
enhancement New feature or request target-1.4.0 Fixed in v1.4.0

Comments

@apocalyptech
Copy link
Contributor

Will need some one-time conversion stuff in there, and the ability to discern between a converted version.
@apocalyptech apocalyptech added the enhancement New feature or request label Apr 24, 2023
@apocalyptech
Copy link
Contributor Author

Actually, taking another look at this, we're basically hardly using this anywhere. There's support for StringTable-backed SelectionOption settings, but nothing's actually using that, and they're apparently used inside the main application error-handling routines. Rather than convert these to CSV, we should just get rid of 'em entirely.

@apocalyptech apocalyptech changed the title Convert StringTable to use a CSV library Convert StringTable to use a CSV library (or more likely, remove StringTable entirely) May 31, 2023
apocalyptech added a commit that referenced this issue Aug 8, 2023
@apocalyptech
Get rid of StringTable. This addresses Issue #6
d92f5e7
@apocalyptech apocalyptech added the target-1.4.0 Fixed in v1.4.0 label Aug 8, 2023
@apocalyptech
Copy link
Contributor Author

Okay, yep, no reason to keep StringTable around. Closing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request target-1.4.0 Fixed in v1.4.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apocalyptech