Allow not escaped commands

[wouterj]

I need to use Bash variables in my commands, e.g.: git push https://${GH_TOKEN}@github.com/.... The ProcessBuilder escapes each argument, resulting in 'git' 'push' 'https://${GH_TOKEN}@gihub.com/'. This causes my build to fail, since the authentication is no longer correct.

I propose to add an option called raw. When it's set to true, it'll simply execute implode(' ', $arguments) instead of using the ProcessBuilder.

[cryptiklemur]

-
    type: exec
    executable: git
    arguments:
        - push
        - https://$GH_TOKEN$@github.com/...

Shouldn't that work?

[wouterj]

@aequasi no, as said, that'll be converted to:

'git' 'push' 'https://$GH_TOKEN@github.com/...'

Anything between single quotes get not parsed, so GH_TOKEN will not be parsed here. This happends on this line of the ProcessBuilder: https://github.com/symfony/Process/blob/master/ProcessBuilder.php#L270

[cordoval]

I am taking the risk here for getting involved in @wouterj's affairs but just want to mention this https://github.com/gushphp/gush/blob/master/src/Helper/ProcessHelper.php#L181-L197 not sure if it is related. I will not continue replying any responses for my sake. 😊

[cryptiklemur]

@wouterj i put in environment variable token support. What i posted will work, but you need the $ after $GH_TOKEN

[cryptiklemur]

https://github.com/bldr-io/bldr/blob/master/src/Call/AbstractCall.php#L304